-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark machine failed during rollout also #733
Merged
himanshu-kun
merged 2 commits into
gardener:master
from
himanshu-kun:fix-rollout-freeze
Jul 20, 2022
Merged
Mark machine failed during rollout also #733
himanshu-kun
merged 2 commits into
gardener:master
from
himanshu-kun:fix-rollout-freeze
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jul 14, 2022
/invite @kon-angelo |
gardener-robot-ci-2
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 14, 2022
gardener-robot
added
needs/review
Needs review
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
labels
Jul 14, 2022
@kon-angelo You have pull request review open invite, please check |
himanshu-kun
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 18, 2022
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 18, 2022
Do I get it correctly:
|
Yes that is correct |
kon-angelo
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Jul 18, 2022
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 18, 2022
himanshu-kun
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 20, 2022
gardener-robot-ci-2
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jul 20, 2022
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A bug where MCM was not marking machine as failed during rollout has been resolved.
In situation where the all the machines in the new or the old machineset go into
Unknown
state , as per the current logic the rollout would stop and won't proceed until we manually delete the machine.This happens because machineSet controller is not aware of a
Unknown
state and so takes no action, and only machine controller could resolve this situation by marking the machineFailed
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
maxReplacement
value, but after looking back , machine were always markedFailed
during rollout previously also , so this PR just kind of goes back to the previous logicRelease note: